Tilted
..
How the law works on this isn't absolutely clear. But I think the best reading of current law is that President Trump wouldn't lose his Secret Service protection even if he was convicted in the impeachment trial. There's some nuance in the law which we can explore if you'd like.I don’t think he loses his pension or secret service detail without a specific vote on that.
But when it comes to certain benefits - e.g., office space, staffing allowance, annual monetary allowance - he would lose those if he was removed from office by impeachment and conviction. Because of how the law is worded though, that would only happen if that were how he left office. So if he left office at the expiration of his term, and then were later convicted in an impeachment trial, he wouldn't lose those benefits. Removal as a result of impeachment conviction wouldn't be how he left office.